Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options import regression #6220

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Jul 18, 2023

there was a bug in the boolean logic of checkIntegrity(), introduced in #6094

(while testing I noticed that the selected LAF is stored in /config/Preferences/laf.properties, so to import the LAF setting (other than font colors and custom LAF properties which are in /config/LookAndFeel/), one would have to select the General category which is importing several other settings too.)

targets delivery

fixes #6214

there was a bug in the boolean logic of checkIntegrity()
@mbien mbien added Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 18, 2023
@mbien mbien added this to the NB19 milestone Jul 18, 2023
@mbien mbien requested a review from pepness July 18, 2023 15:21
@mbien mbien linked an issue Jul 18, 2023 that may be closed by this pull request
@mbien mbien added the Regression This used to work! label Jul 18, 2023
@neilcsmith-net
Copy link
Member

Aside : yes, I added the /config/LookAndFeel with registration. As mentioned at #4719 (comment) and not that I've got around to it, we could consider moving that folder and laf.properties under a single Look and Feel section.

@mbien mbien marked this pull request as ready for review July 18, 2023 16:10
@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 18, 2023
Copy link
Member

@pepness pepness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that this PR fix ISSUE-6214. Great work @mbien.

@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 18, 2023
@neilcsmith-net neilcsmith-net merged commit 49b6539 into apache:delivery Jul 20, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*) Regression This used to work!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options to Import does not work correctly
3 participants