-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GlassFish 7.0.6 #6221
Conversation
- Add support of the MicroProfile REST Client - Add a new way to start GlassFish - Add support for using @Inject to inject REST artifacts - Bug fixes and updates of various components - Bump the GlassFish version in some tests
Sorry for been late, I think it is important that a new NetBeans release support the latest version of GlassFish and Tomcat/TomEE. |
just as general comment: we should try to find ways how to reduce the changes needed for "simple" updates like this one here. It can't be that we have to edit 8 files because a new glassfish point release dropped. ideally the UI would check for updates e.g by looking at https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/maven-metadata.xml and offer downloads on a best effort basis until something breaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i diffed:
https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/6221.diff
with
https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/6002.diff
and the changes look good to me.
going to add do-not-merge so that nobody outside of the release team merges this by accident I think its probably OK to merge since the change is fairly isolated from everything and has no real risk of causing regressions.
No need for the label - we use that already for things we really don't want merged so it's going to get confusing! 😉 If someone isn't paying attention we can always force push delivery back to the right state. |
Will merge for rc2. @mbien am I missing it, or are the tests updated here not run on GH? |
@neilcsmith-net correct, they don't run on CI yet. A lot of tests need to be hooked into the enterprise job still. @asbachb was helping with that in his PRs. |
@mbien thanks, that's fine - got in the habit of checking before merging when I see test changes in a PR. |
Library Notes:
NetBeans Testing:
ant -Dcluster.config=release commit-validation
glassfish.common
,glassfish.javaee
,glassfish.tooling
andglassfish.eecommon
Release Notes