Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GlassFish 7.0.6 #6221

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

pepness
Copy link
Member

@pepness pepness commented Jul 18, 2023

Library Notes:

  • Add support of the MicroProfile REST Client
  • Add a new way to start GlassFish
  • Add support for using @Inject to inject REST artifacts
  • Bug fixes and updates of various components
  • Bump the GlassFish version in some tests

NetBeans Testing:

  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of Verify Sigtests
  • Verify successful execution of ant -Dcluster.config=release commit-validation
  • Verify successful execution of unit tests for modules glassfish.common, glassfish.javaee, glassfish.tooling and glassfish.eecommon
  • Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
  • Successfully register GlassFish 7.0.6, create a web app and verify that it works.

Release Notes

- Add support of the MicroProfile REST Client
- Add a new way to start GlassFish
- Add support for using @Inject to inject REST artifacts
- Bug fixes and updates of various components
- Bump the GlassFish version in some tests
@pepness pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Jul 18, 2023
@pepness pepness added this to the NB19 milestone Jul 18, 2023
@pepness pepness self-assigned this Jul 18, 2023
@pepness
Copy link
Member Author

pepness commented Jul 18, 2023

Sorry for been late, I think it is important that a new NetBeans release support the latest version of GlassFish and Tomcat/TomEE.

@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label Jul 19, 2023
@mbien
Copy link
Member

mbien commented Jul 19, 2023

just as general comment: we should try to find ways how to reduce the changes needed for "simple" updates like this one here. It can't be that we have to edit 8 files because a new glassfish point release dropped.

ideally the UI would check for updates e.g by looking at https://repo1.maven.org/maven2/org/glassfish/main/distributions/glassfish/maven-metadata.xml and offer downloads on a best effort basis until something breaks.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i diffed:
https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/6221.diff
with
https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/6002.diff
and the changes look good to me.

going to add do-not-merge so that nobody outside of the release team merges this by accident I think its probably OK to merge since the change is fairly isolated from everything and has no real risk of causing regressions.

@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 19, 2023
@neilcsmith-net
Copy link
Member

No need for the label - we use that already for things we really don't want merged so it's going to get confusing! 😉 If someone isn't paying attention we can always force push delivery back to the right state.

@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 19, 2023
@neilcsmith-net
Copy link
Member

Will merge for rc2.

@mbien am I missing it, or are the tests updated here not run on GH?

@neilcsmith-net neilcsmith-net merged commit de8dde7 into apache:delivery Jul 20, 2023
34 checks passed
@mbien
Copy link
Member

mbien commented Jul 20, 2023

@neilcsmith-net correct, they don't run on CI yet. A lot of tests need to be hooked into the enterprise job still. @asbachb was helping with that in his PRs.

@neilcsmith-net
Copy link
Member

neilcsmith-net commented Jul 20, 2023

@mbien thanks, that's fine - got in the habit of checking before merging when I see test changes in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants