Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlatLaf from 3.1 to 3.2 #6362

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

eirikbakke
Copy link
Contributor

This is a simple upgrade of the FlatLaf library from version 3.1 to 3.2, modeled after the previous version bump at #5818 .

Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/3.2

The new Windows ARM support DLL was added the list of native libraries automatically extracted from the JAR.

(I needed the update in my own NetBeans build, so offered @DevCharly to prepare the version bump PR this time.)

Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/3.2

The new Windows ARM support DLL was added the list of native libraries automatically extracted from the JAR.
@eirikbakke eirikbakke added Upgrade Library Library (Dependency) Upgrade Look and Feel labels Aug 19, 2023
@mbien mbien added this to the NB20 milestone Aug 20, 2023
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Aug 20, 2023
@apache apache locked and limited conversation to collaborators Aug 20, 2023
@apache apache unlocked this conversation Aug 20, 2023
@mbien
Copy link
Member

mbien commented Aug 20, 2023

cool! Told CI to generate a dev-build to make it easier to test.

@mbien
Copy link
Member

mbien commented Aug 20, 2023

fixes #5917, see JFormDesigner/FlatLaf#701

@mbien mbien linked an issue Aug 20, 2023 that may be closed by this pull request
@mbien
Copy link
Member

mbien commented Aug 20, 2023

noticed that the tabs in the options (and java platform manager) have rounded corners on the top, main window tabs are as usual. I don't mind it tbh.
image

@eirikbakke
Copy link
Contributor Author

Good catch; for consistency with the regular document tabs, I added an adjustment (in a separate commit to be squashed) to FlatLaf.properties that restored the un-rounded tabs from previous versions:

removerounded

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thanks for fixing the rounded tabs. I assume this was also affecting sub-tabs in the output window, etc.

Aside : I sometimes wish UI defaults / changes like the tabs were treated as part of semantic versioning - such things should be opt-in not opt-out IMO.

@eirikbakke eirikbakke merged commit 14c3a1c into apache:master Aug 24, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Look and Feel Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse pointer not selecting the last item in the hints list
4 participants