Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add build-from-src-zip job #6579

Merged
merged 1 commit into from Oct 25, 2023
Merged

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 17, 2023

Build from src zip for release and platform in a separate job. This simplifies the platform job too as side effect.

Do we want to do this every time or only when certain labels are set? ( Platform [ci] enable platform tests (platform/*) , VSCode Extension [ci] enable VSCode Extension tests , ci:all-tests [ci] enable all tests and on master?)

this PR is intended to fail until #6583 made it back to master

@mbien mbien added the CI Continuous Integration label Oct 17, 2023
@neilcsmith-net
Copy link
Member

Yes, might not want to do this on every run.

We really need to have building the VSCode plugin tied in to the release cluster build here too. Given that's the failure that prompted this.

@mbien
Copy link
Member Author

mbien commented Oct 17, 2023

Yes, might not want to do this on every run.

yep, had the same thoughts

We really need to have building the VSCode plugin tied in to the release cluster build here too. Given that's the failure that prompted this.

this might be the missing puzzle piece:

  CLUSTER_CONFIG: ${{ (contains(github.event.pull_request.labels.*.name, 'rust') || github.event_name != 'pull_request') && 'full' || 'release' }}

we are so lucky that fake ternary ops work! We could build the full cluster only when rust is specified in PRs? What should happen on the master branch, post-merge?

edit: discussed this on slack a bit and we going to leave it on the full cluster config for now

@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Oct 17, 2023
@mbien
Copy link
Member Author

mbien commented Oct 17, 2023

well.. that job was supposed to fail. Lets stash this and try it plan b.

@mbien
Copy link
Member Author

mbien commented Oct 18, 2023

 BUILD FAILED
/home/runner/work/netbeans/netbeans/tmpbuild/java/java.lsp.server/build.xml:131: Cannot resolve rust.cargo. Neither one exist:
  /home/runner/work/netbeans/netbeans/tmpbuild/rust.cargo
  /home/runner/work/netbeans/netbeans/tmpbuild/rust/rust.cargo
Total time: 2 minutes 44 seconds
Error: Process completed with exit code 1.

it worked! success!

@mbien mbien added VSCode Extension [ci] enable VSCode Extension tests and removed do not merge Don't merge this PR, it is not ready or just demonstration purposes. labels Oct 18, 2023
@neilcsmith-net
Copy link
Member

Never been happier to see failing tests! 😄

@mbien mbien force-pushed the ci-build-from-src-zip branch 2 times, most recently from 6c31df0 to b3abeeb Compare October 18, 2023 11:24
@mbien mbien added this to the NB21 milestone Oct 18, 2023
@mbien mbien marked this pull request as ready for review October 18, 2023 13:25
@mbien mbien mentioned this pull request Oct 24, 2023
builds platform, release and NB vscode extension from src zips.
@mbien
Copy link
Member Author

mbien commented Oct 25, 2023

rebased. should be green now if everything goes according to plan

edit: tests are green -> merging

@mbien mbien merged commit 20ee034 into apache:master Oct 25, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants