Fix unnamed main method detection #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code gave wrong results when other methods were nearby.
mbien
added
Java
MartinBalin
approved these changes
Oct 23, 2023
| @@ -1085,22 +1090,15 @@ private static boolean mainCandidate(ExecutableElement method) { | |||
| return true; | |||
| } | |||
|
|
|||
| // 0 is highest | |||
There was a problem hiding this comment.
Thanks for adding this comment! I just spent a couple of minutes looking at your loop wondering why the check was that way around. 😆
There was a problem hiding this comment.
I actually rewrote it at first since I thought that was the actual bug! Then I left the comment for the next brave dev who reads the code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code gave wrong results when other methods were nearby.