Terminal, Output and Syntax Coloring options UI cleanup. #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- made font pickers wider so that the font columns render better - adjusted component gaps and layouts for consistency - basic code cleanup
mbien
added
Code cleanup
Editor
UI
lkishalmi
reviewed
Nov 6, 2023
| } | ||
| try { | ||
| in.close(); |
There was a problem hiding this comment.
Just a nuance, caught my attention to get a reader closed in AWT, made me worry if we do write on that stream on a different thread.
Removing the otherwise unused in variable and use previewInputOutput.getIn().close() would make this more clear.
There was a problem hiding this comment.
yeah this looks weird but I believe getIn() does more than just opening a stream:
If a reader is ever requested, an input line is added to the tab and used to read one line at a time.
this sounds like it makes a visual difference and is the reason why it is opened that early and closed once it displayed something - but i could be wrong.
|
master is green, lets merge something :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best way to see the difference is to toggle between the terminal and output tab (misc options) in NB 20, then again with this dev build.
(sorry for the bright orange, this is just to mark my local dev build)