Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIT: Removed unnecessary separators from the git toolbar #6709

Merged
merged 1 commit into from Nov 17, 2023
Merged

GIT: Removed unnecessary separators from the git toolbar #6709

merged 1 commit into from Nov 17, 2023

Conversation

troizet
Copy link
Collaborator

@troizet troizet commented Nov 16, 2023 •
edited

There are separators on the git toolbar that only show up in the metal theme, and they display oddly.
This PR removes these separators.

Toolbar in metal theme:
before:
metal_before
after:
metal_after

Toolbar in nimbus theme:
before:
nimbus_before
after:
nimbus_after

Toolbar in motif theme:
before:
motif_before
after:
motif_after

Toolbar in gtk theme:
before:
gtk_before
after:
gtk_after

Toolbar in flatlaf theme:
before:
flatlaf_before
after:
flatlaf_after

@mbien mbien added UI User Interface git [ci] enable versioning job labels Nov 16, 2023
@mbien mbien added this to the NB21 milestone Nov 16, 2023
mbien
mbien approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! interesting that this is only causing issues with metal

neilcsmith-net
neilcsmith-net approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'd totally forgotten about those - https://lists.apache.org/thread/m9oxbrpf3sfh41kcvxsghhzs81b4py1r

@mbien mbien merged commit 1389312 into apache:master Nov 17, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@neilcsmith-net neilcsmith-net neilcsmith-net approved these changes

Assignees
No one assigned
Labels
git [ci] enable versioning job UI User Interface
Projects
None yet
Milestone
NB21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@troizet @mbien @neilcsmith-net