Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the formatting for a method invocation with a ternary or null-coalescing operator #5380 #6724

Merged

Conversation

junichi11
Copy link
Member

…lescing operator apache#5380

- apache#5380
- Add whitespaces after `UNBREAKABLE_SEQUENCE_END` token
- Check whether there is a whitespace token before an indent token
- Add unit tests
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Nov 19, 2023
@junichi11 junichi11 added this to the NB21 milestone Nov 19, 2023
@junichi11 junichi11 linked an issue Nov 19, 2023 that may be closed by this pull request
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@junichi11 junichi11 merged commit d3ebc8b into apache:php-nb21-features Nov 19, 2023
34 checks passed
@junichi11 junichi11 deleted the php-gh-5380-ternary-formatting branch November 19, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP: Extra space after ternary operator in method call
2 participants