New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jaxb maven plugin and handle javax and jakarta namespaces #6736
Conversation
I intent to merge this by next week, so if anyone wants to object, please do so now. |
I tested with a fresh user config and a plain maven project and the wizard (using remote xsd file) seems to require the EE cluster to be enabled, otherwise pressing finish won't do anything. It will log this exception quietly:
might be some ergonomics issue? edit: worked fine post manual activation |
Thanks for testing. This behavior is not new (reproducible on NB19) and in review kind of expected. The maven schema compiler module is provided by |
right, its not a regression. Its just that having no user feedback (not even an exception dialog) after pressing finish isn't ideal. Maybe we should use |
…ion for maven projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Thanks for the user notification change, fairly elegant solution IMO, I mainly suggested to not suppress the exception and update the msg a little bit - but this is better.
Closes: #6534