Ability to work with JDK 22 ea javac. #6742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
added
the
Java
|
@lahodaj Could you add some comments why this change is necessary? I guess it would be educational. |
|
This appears to be be cleanup/refactoring which makes NB compatible both with both javac 21 and upstream 22 due to the mentioned api changes (thanks for updating the PR msg). NB 21 release is planned for end of February, while JDK 22 would be March 19th. Should we move this to milestone 22 or merge? |
|
i believe this can be closed since changes here are part of https://github.com/apache/netbeans/pull/6968/files which is already integrated. I am not quite sure why github isn't updating the diff here. |
mbien
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the javac internals used by NB have changed - in particular the
com.sun.tools.javac.util.Namehas been changed:openjdk/jdk@11da15d
This change is adjusting to that - by reducing the use of the internal API, and relying more on the public API.