Centralize internal maven artifact version queries. #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
commented
Nov 26, 2023
| @@ -17,7 +17,6 @@ | |||
|
|
|||
| javac.source=1.8 | |||
There was a problem hiding this comment.
modules which use nb-javac can't change their source level at the moment since they prepend the bootclasspath and this is only allowed on java 8.
Since target isn't (and can't) be set either once boot cp is modified, no API checks are active. Going to file an issue with more details.
There was a problem hiding this comment.
filled as issue so that we don't forget #6817
java/maven/src/org/netbeans/modules/maven/options/NbArtifactVersionPreferences.java
Outdated
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/options/MavenVersionSettings.java
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/options/NbArtifactVersionPreferences.java
Outdated
Show resolved
Hide resolved
- put all hardcoded fallback versions in one place - use index for updates if available
mbien
force-pushed
the
mvn-version-defaults
branch
from
cc86fe1
to
92080ad
Compare
matthiasblaesing
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes https://issues.apache.org/jira/browse/NETBEANS-6491 as side effect
note: its all internal, and only used in two modules for now