PHP 8.3 Support: Dynamic class constant fetch #6701 #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junichi11
force-pushed
the
php83-dynamic-class-constant-fetch
branch
from
b14721e
to
e53b927
Compare
|
@tmysik Could you please have a look at each commit when you have time? |
tmysik
reviewed
Nov 27, 2023
php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/StaticConstantAccess.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Nov 27, 2023
php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/StaticConstantAccess.java
Outdated
Show resolved
Hide resolved
tmysik
reviewed
Nov 27, 2023
php/php.editor/test/unit/src/org/netbeans/modules/php/editor/PHPBracesMatcherTest.java
Show resolved
Hide resolved
tmysik
reviewed
Nov 27, 2023
php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP55UnhandledError.java
Outdated
Show resolved
Hide resolved
tmysik
approved these changes
Nov 27, 2023
- apache#6701 - https://wiki.php.net/rfc/dynamic_class_constant_fetch - Fix the grammar file (parser) - Add the `PHP83UnhandledError` - Add/Fix unit tests for the parser Example: ```php class Example { const CONSTANT = 'constant'; } $constant = 'CONSTANT'; echo Example::{$constant}; ```
- apache#6701 - https://wiki.php.net/rfc/dynamic_class_constant_fetch - Fix the `SemanticAnalysis` - Fix the mark occurrences and the go to declaration features - Add unit tests
- apache#6701 - https://wiki.php.net/rfc/dynamic_class_constant_fetch - Fix the formatter - Add the option of the around spaces for the scope resolution operator (`::`) - Don't add spaces within braces (`{}`) e.g. {$example} - Add unit tests
- apache#6701 - https://wiki.php.net/rfc/dynamic_class_constant_fetch - Fix the code completion feature - Add unit tests for the code completion and brace matching features
- apache#6701 - https://wiki.php.net/rfc/dynamic_class_constant_fetch - Fix the `IntroduceSuggestion` and `PHP55UnhandledError` - Add unit tests
junichi11
force-pushed
the
php83-dynamic-class-constant-fetch
branch
from
e53b927
to
7e70563
Compare
|
@tmysik Fixed : https://github.com/apache/netbeans/compare/e53b9278c63011edf23dc592d66827e77d98edbe..7e705639b19ce57a0fe0984cdc8e91ac2f4272bc Thank you for your review and your time :) |
|
@junichi11 Nothing to thank for, really. NetBeans users have to thank you, Junichi. Without you, there would not be any up-to-date PHP support in NetBeans at all! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.3 Support: Add PHP 8.3 to the PhpVersion
PHP 8.3 Support: Dynamic class constant fetch (Part 1)
PHP83UnhandledErrorExample:
PHP 8.3:
PHP 8.2:
PHP 8.3 Support: Dynamic class constant fetch (Part 2)
SemanticAnalysisPHP 8.3 Support: Dynamic class constant fetch (Part 3)
::){}) e.g. {$example}PHP 8.3 Support: Dynamic class constant fetch (Part 4)
PHP 8.3 Support: Dynamic class constant fetch (Part 5)
IntroduceSuggestionandPHP55UnhandledError