Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven dependency update hint and version completion for pom profiles. #6765

Merged
merged 1 commit into from Dec 9, 2023
Merged

Maven dependency update hint and version completion for pom profiles. #6765

merged 1 commit into from Dec 9, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Nov 29, 2023 •
edited

  • properties set in profiles should be taken into account by the dependency update hint
  • implemented auto completion for property values in profiles which are used for artifact version fields

Still has the same limitation as before: property and usage has to be in the same pom.

pom-profiles-hint-completion
(mouse pointer is hovering over the light bulb to get the tooltip)

although the code starts to look complicated and there are likely ways to optimize this, it is still quite fast - so I didn't bother:

pom hints>>>
0 org.netbeans.modules.maven.hints.pom.ReleaseVersionError@4784a871
0 org.netbeans.modules.maven.hints.pom.OverridePluginManagementError@ea3dc5f
0 org.netbeans.modules.maven.hints.pom.OverrideDependencyManagementError@1686f435
0 org.netbeans.modules.maven.hints.pom.ParentVersionError@c869770
0 org.netbeans.modules.maven.hints.pom.JavaNetRepositoryError@25fde6ed
0 org.netbeans.modules.maven.hints.pom.CompilerPluginVersionError@2cafc207
1 org.netbeans.modules.maven.hints.pom.UseReleaseOptionHint@6db0413e
68 org.netbeans.modules.maven.hints.pom.UpdateDependencyHint@6da023da
<<<done

~70ms for checking all versions of this pom

@mbien
Maven dependency update hint and version completion for pom profiles.
5ac30ec 
 - properties set in profiles should be taken into account by the
   dependency update hint
 - implemented auto completion for property values in profiles which
   are used for artifact version fields

Still has the same limitation as before: property and usage has to be
in the same pom.
@mbien mbien added Maven [ci] enable "build tools" tests hints ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 29, 2023
@mbien mbien added this to the NB21 milestone Nov 29, 2023
matthiasblaesing
matthiasblaesing approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only eyeballed this, but looks sane to me.

@mbien
Copy link
Member Author

mbien commented Dec 9, 2023

thanks, going to merge it so that I can test it together with the other recent maven changes.

@mbien mbien merged commit 775f0f0 into apache:master Dec 9, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@sdedic sdedic Awaiting requested review from sdedic

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) hints Maven [ci] enable "build tools" tests
Projects
None yet
Milestone
NB21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbien @matthiasblaesing