Stacktrace analyzer window fixes #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
commented
Dec 14, 2023
There was a problem hiding this comment.
recommend to enable ignore whitespace changes for reviewing this one - sorry about this
|
there you go, found the evil logger: see #6843 and apache/maven#1342 |
mbien
added
ci:all-tests
mbien
force-pushed
the
stacktrace-analyzer-fixes
branch
from
7535f37
to
3101fde
Compare
mbien
force-pushed
the
stacktrace-analyzer-fixes
branch
from
3101fde
to
8cd2066
Compare
mbien
commented
Dec 17, 2023
Comment on lines
57
to
+63
| private static final Pattern LINE_PATTERN = Pattern.compile( | ||
| "at\\s" + // initial at // NOI18N | ||
| "at\\s+" + // initial at // NOI18N | ||
| "("+IDENTIFIER+"(?:\\."+IDENTIFIER+")*/)?" + // optional module name // NOI18N | ||
| "(("+IDENTIFIER+"(\\."+IDENTIFIER+")*)\\.)?("+IDENTIFIER+")" + // class name // NOI18N | ||
| "\\.("+IDENTIFIER+"|\\<init\\>|\\<clinit\\>)\\((?:"+IDENTIFIER+"(?:\\."+IDENTIFIER+")*/)?" +IDENTIFIER+"\\.?("+IDENTIFIER+ // method and file name // NOI18N | ||
| ")\\:([0-9]*)\\)"); // line number // NOI18N | ||
| "\\.("+IDENTIFIER+"|\\<init\\>|\\<clinit\\>)\\s*"+ // method name | ||
| "\\((?:"+IDENTIFIER+"(?:\\."+IDENTIFIER+")*/)?"+IDENTIFIER+"(\\.(?:\\p{javaJavaIdentifierPart}+))?"+ // '(File.java' // NOI18N | ||
| "\\:([0-9]*)\\)"); // ':123)' // NOI18N |
There was a problem hiding this comment.
the original goal was to add a few optional \\s* but this does also include a fix for https://github.com/apache/netbeans/pull/6640/files#r1377502665, since this didn't work before as pointed out by @dbalek in the linked review.
The file extension group is now optional (\\.(?:\\p{javaJavaIdentifierPart}+))? and matches more character types since extensions aren't real java identifiers. Tests cover this now too.
matthiasblaesing
approved these changes
Dec 17, 2023
java/java.navigation/src/org/netbeans/modules/java/stackanalyzer/StackLineAnalyser.java
Outdated
Show resolved
Hide resolved
java/java.navigation/src/org/netbeans/modules/java/stackanalyzer/StackLineAnalyser.java
Outdated
Show resolved
Hide resolved
- update matcher to be more forgiving when traces are pasted from ANSI decorated sources (some loggers use colors for exception elements) - some loggers add extra spaces to stack trace lines - properly escape angle brackets in cell renderer - some indentation fixes for lines which are rendered without link (e.g native code calls) - avoid using deprecated methods
mbien
force-pushed
the
stacktrace-analyzer-fixes
branch
from
8cd2066
to
5fc30b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g native code calls)
example: this trace isn't parsed properly NB 20 (note: the space before '('):
even if the space is manually removed the result could be better (missing
<init>, broken indentation on at-lines which can't be linked):with this PR applied:
