Allow user to manipulate Truffle breakpoints #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtulach
requested review from
entlicher,
dbalek,
MartinBalin,
sdedic and
lahodaj
MartinBalin
approved these changes
Dec 22, 2023
sdedic
approved these changes
Jan 11, 2024
dbalek
approved these changes
Jan 22, 2024
|
will merge this as approved |
|
the tests here ran the last time in December if i see this correctly. Unfortunately this is breaking master atm. I am going to prepare a revert PR but let others decide what to do, since many work at a GraalJS update atm so it might have to be coordinated. |
|
-> #7261 |
|
@jtulach it would be good if you could revisit this. The functionality indeed looks useful, but needs another look (see the necessary revert). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging programs with Truffle based languages it may be useful to disable the Truffle functionality (as it may slow down the debugging a lot - for example running tests on mine graaljs-websocket is quite slow - looks like the VM runs in interpreter only). Currently the only way to disable Truffle breakpoints is to disable the whole module.
This PR offers a different way: It exposes the Truffle breakpoints to the user (under the group
Truffle) which can then be disabled as a whole with a single click.What do you think, @entlicher?