Drop special mimetype for karma test configuration #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The karma test configuration (default filename: karma.conf.js) was mapped to the special mimetype text/karmaconf+javascript. The mimeresolver for that matched for all files, that ended with js and contained "karma" or "conf". This collides with the JS editor infrastructure, that does not allow for this subclassing. Oen such problem was, that for file JS folding was provided, but the fold types were not provided, raising exceptions from GsfFoldManager. Instead of special casing the file to a mimetype, the action is now tied to all JS files, but only activated (and visible) on karma*.conf.js files. Closes: apache#6879
matthiasblaesing
added
JavaScript
|
@mbien thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The karma test configuration (default filename: karma.conf.js) was mapped to the special mimetype text/karmaconf+javascript.
The mimeresolver for that matched for all files, that ended with js and contained "karma" or "conf". This collides with the JS editor infrastructure, that does not allow for this subclassing. Oen such problem was, that for file JS folding was provided, but the fold types were not provided, raising exceptions from GsfFoldManager.
Instead of special casing the file to a mimetype, the action is now tied to all JS files, but only activated (and visible) on karma*.conf.js files.
Closes: #6879