Make NetBeans aware of the StringTemplate.STR default field import. #6908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- auto import after paste should not import STR - organize imports and fix imports should not import STR - java.lang imports removal hint should suggest removal of 'import static java.lang.StringTemplate.STR' too - handling of StringTemplate.RAW should remain unchanged since it is not a default import
mbien
added
Java
|
thanks for the review! If java happens to add more of those default static imports we should centralize the logic somehow. So that it isn't implemented three times in slightly different ways. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STRSTRjava.langimports removal hint should suggest removal of 'import static java.lang.StringTemplate.STR' tooStringTemplate.RAWshould remain unchanged since it is not a default importquote from JEP 430:
test:
paste this into a JDK 21+ project with preview enabled:
it should only suggest
RAWas import.The redundant lang import hint should now know about STR too:
