Fix the named argument code completion for constructors #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmysik
reviewed
Jan 4, 2024
php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java
Outdated
Show resolved
Hide resolved
tmysik
approved these changes
Jan 4, 2024
|
@tmysik Thank you for your review! I'll fix it. |
- Show argument names in consturctors - Don't add `:` if an existing name has `:` (an improvement) e.g. ^maxLength: (^: caret) We are unsure whether a user expects to add or override an item in this context. So, just add a name. (i.e. don't add ":") This behavior is useful when the consuming completion(<kbd>Ctrl</kbd> + <kbd>Enter</kbd>) is used. - Add unit tests
junichi11
force-pushed
the
php-named-argument-cc-for-constructor
branch
from
1056bc2
to
24ba6df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:if an existing name has:(an improvement)e.g. ^maxLength: (^: caret)
We are unsure whether a user expects to add or override an item in this context. So, just add a name. (i.e. don't add ":")
This behavior is useful when the consuming completion(Ctrl + Enter) is used.
Before:
After: