Ignore scope inheritance for configs not present in the project. #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
Gradle
MartinBalin
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds NPE check to
GradleScopeBuilder, as there are pre-defined 'abstract' scopes that inherit from Gradle configurations ... but they do not need to be present at all in a gradle project.During investigation of a bug I've added some more logging to gradle dependency implementation, I'd retain it.
Finally, from the inception of Vulnerability Audit implementation, and introduction of
Diagnostic.ReporterControl, there is a potential race on write toTextDocumentService.diagnosticTasks; simple synchronize() should solve that. I've been 'just lucky' to encounter it during development.