Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the code completion for predefined attributes #6951

Merged
merged 2 commits into from Jan 13, 2024
Merged

Fix the code completion for predefined attributes #6951

merged 2 commits into from Jan 13, 2024

Conversation

junichi11
Copy link
Member

Example:

 #[^]
 class Example {
 }

Before:

 #[^] // predefined attributes are not shown except for the Attribute attribute
 class Example {
 }

After:

 #[^] // all predefined attributes are shown
 class Example {
 }

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jan 13, 2024
@junichi11 junichi11 added this to the NB21 milestone Jan 13, 2024
@junichi11 junichi11 requested a review from tmysik January 13, 2024 03:43
tmysik
tmysik approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@junichi11
Fix the code completion for predefined attributes
84931f4 
- https://www.php.net/manual/en/reserved.attributes.php
- Add all predefined attributes to `PredefinedSymbols` as enum
- Add a unit test

Example:

```php
 #[^]
 class Example {
 }
```

Before:

```php
 #[^] // predefined attributes are not shown except for the Attribute attribute
 class Example {
 }
```

After:

```php
 #[^] // all predefined attributes are shown
 class Example {
 }
```
@junichi11
Use PredefinedSymbols.Attributes.OVERRIDE instead of `CodeUtils.OVE…
e79431d 
…RRIDE*`
@junichi11 junichi11 force-pushed the php-fix-cc-for-predefined-attributes branch from 3959424 to e79431d Compare January 13, 2024 14:34
@junichi11
Copy link
Member Author

Thank you, Tomas! We can merge this into NB21, thanks to you :) (Feature freeze: January 16th) I'll merge this after CI passes.

@tmysik
Copy link
Member

tmysik commented Jan 13, 2024

@junichi11 Not thanks to me but thanks to you, if course! 👍

@junichi11 junichi11 merged commit 2a616c3 into apache:master Jan 13, 2024
34 checks passed
@junichi11 junichi11 deleted the php-fix-cc-for-predefined-attributes branch January 13, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@junichi11 @tmysik