Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect formatting after use statements #6980 #6981

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fix incorrect formatting after use statements #6980 #6981

merged 1 commit into from
Jan 21, 2024

Conversation

junichi11
Copy link
Member

Example:

<?php
namespace {
    use Vendor\Class1;
    $test = 1;
}

Before:

<?php

namespace {

    use Vendor\Class1;

$test = 1;
}

After:

<?php

namespace {

    use Vendor\Class1;

    $test = 1;
}

@junichi11
Fix incorrect formatting after use statements apache#6980
452a636 
- apache#6980
- Fix the below case
- Add unit tests

Example:

```php
<?php
namespace {
    use Vendor\Class1;
    $test = 1;
}
```

Before:

```php
<?php

namespace {

    use Vendor\Class1;

$test = 1;
}
```

After:

```php
<?php

namespace {

    use Vendor\Class1;

    $test = 1;
}
```
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jan 21, 2024
@junichi11 junichi11 added this to the NB22 milestone Jan 21, 2024
@junichi11 junichi11 changed the base branch from master to php-nb22-features January 21, 2024 05:18
@junichi11 junichi11 linked an issue Jan 21, 2024 that may be closed by this pull request
Wrong indentation after use statements #6980
Closed
@junichi11 junichi11 requested a review from tmysik January 21, 2024 09:02
tmysik
tmysik approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@junichi11 junichi11 merged commit 35a83e0 into apache:php-nb22-features Jan 21, 2024
34 checks passed
@junichi11 junichi11 deleted the php-gh-6980-incorrect-formatting branch January 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB22
Development

Successfully merging this pull request may close these issues.

Wrong indentation after use statements
2 participants
@junichi11 @tmysik