New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: Implemented display of exception message when exception breakpoints are hit #6992
PHP: Implemented display of exception message when exception breakpoints are hit #6992
Conversation
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Show resolved
Hide resolved
Thank you for the example code and screenshots! It's easy to understand :) |
@troizet Could you change the target branch from the |
401c2ce
to
9793949
Compare
I made the suggested changes and rebased the branch. |
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/BreakpointModel.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/packets/RunResponse.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several comments added, please look into them. Thanks for your work!
9793949
to
18792e6
Compare
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Outdated
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Show resolved
Hide resolved
php/php.dbgp/src/org/netbeans/modules/php/dbgp/breakpoints/ExceptionBreakpoint.java
Outdated
Show resolved
Hide resolved
Looks good to me, with just one change remaining. Please, look into it. Thanks! |
18792e6
to
da5a813
Compare
Looks good to me now. What about @junichi11? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for your work!
Thank you, guys! Merging. |
The implementation is made for xdebug since version
3.1.6
.Tested on versions of xdebug:
3.1.6
,3.2.0
,3.3.0
.Code example:
before:
before.mp4
after:
after.mp4
for
throw new MyException("Test exception breakpoint")
it looks like this:for
throw new MyException("", 42)
it looks like this:for
throw new MyException("")
andthrow new MyException()
it looks like this:How it looks in a dark theme: