Code Cleanup/Deprecation fixes: Class#newInstance, underscore identifier, better temp files, avoid toUpper/LowerCase and more

[mbien]

Contains project wide cleanups/refactorings/deprecation fixes:

• Prefer Files#createTempFile over File#createTempFile.
  • Files.createTempFile uses more restrictive file permissions if possible.
• Prefer String.equalsIgnoreCase() over toUpper/LowerCase patterns
  • String.toUpper/LowerCase() without setting Locale.ROOT can lead to unintended results on certain locales.
  • followup to Replaced usage of String.to[U/L]Case() with String.equalsIgnoreCase() #5219
• Replace single underscore identifiers with regular names. _ is a reserved keyword since java 8
• Fix Class#newInstance deprecation warnings
  • c.getDeclaredConstructor().newInstance() can be used instead
  • simplified exception handling in related code
• Prefer list.sort(comp) over Collections.sort(list, comp)
  • more fluent / one import less in many cases
  • (there is no sort method without Comparator, we could in theory map Collections.sort(list) to list.sort(null), but I left those cases out since this might look confusing)
• More efficient col.toArray()
  • zeroing step is skipped with col.toArray(new T[0]) or (T::new)
  • easier to optimize for the JVM
  • shorter/easier to read
  • large commit which is split into 6 parts along cluster boundaries

All changes were made using either jackpot scripts or built-in NetBeans code transformations. The Class#newInstance change needed some adjustments per hand, since due to slightly different exception handling.

I looked through the patch files twice, except the toArray() change which I only looked through once due to its size. I only had to tweak minor formatting anomalies here and there.

[mbien]

@junichi11 @troizet want to look through the PHP commit? (or any other commits you are interested in)

[junichi11]

We have the PHP feature branch for NB22. So, please merge this after we merge the PHP feature branch. (I'm going to merge it into the master after NB21 is released.) Thanks.

cc: @tmysik

[mbien]

@junichi11 yes saw it already, I won't merge before some of the larger pending PRs are integrated.

[tmysik]

@mbien

Thanks a lot for doing this, Michael!

[mbien]

I think a good way of reviewing cleanups like this is to let github generate a diff patch for a commit, e.g:
https://github.com/apache/netbeans/pull/7053/commits/32a42b5994652483cc5bd9a4713a6941d175ae4b.diff (simply add .diff to any URL)
unfortunately the browser doesn't show this in color, so I download it and open it in NB. This makes scanning through it really easy and fast.

Also for the reviewers: please mention what parts you reviewed in the approve comment so that I get an idea of what is reviewed and what is not

[matthiasblaesing]

I eyeballed samples from all commits. The changes looks sane to me and nothing out of the ordinary jumped out. Thank you.

[junichi11]

Can't use compareToIgnoreCase?

[mbien]

oh interesting, I didn't know that this method existed. I did only transform to equalsIgnoreCase()

I might do this at a later point since this PR is already large enough.
But i am going to add this to my hints collection for sure https://github.com/mbien/jackpot-inspections
thanks!

[mbien]

looking closer at the method it likely has unintended side effects since it sorts the array in-place, and then it returns a copy via toArray() (which makes no sense).

other implementations do copy first, sort it and return the copy:
https://github.com/search?q=repo%3Aapache%2Fnetbeans%20getSortedProjects&type=code

should I change it to:

    public static Provider[] getSortedProjects(Provider[] projects) {
        Provider[] sorted = Arrays.copyOf(projects, projects.length);
        Arrays.sort(sorted, (p1, p2) -> getDisplayName(p1).compareToIgnoreCase(getDisplayName(p2)));
        return sorted;
    }

@matthiasblaesing ?

[mbien]

added it as extra commit (the other ProjectUtilities class in ...profiler.nbimpl.project is deprecated and not used for the getSortedProject utility method, only the new ProjectUtilities had this behavior)

[junichi11]

Looks good to me. I've glanced through each commit. Thank you for your work!

[mbien]

• the two largest PRs Snapshot of APIs as of NetBeans 21 #6960 and PHP features for NB22 #7056 are both merged
• rebased to latest master (with no conflict which is a small miracle)

planning to merge once green again

the other PRs should do fine hopefully, I don't expect many conflicts there:

gh pr list --limit 30 --json number,title,changedFiles --template '{{range .}}{{tablerow .number .changedFiles .title}}{{end}}'                                                                                  7089  2     README and CHANGELOG update                                                                                                                                                                                                    
7088  1     Java Code Templates for records and sealed types
7087  11    maven indexing: update lucene from 9.9.1 to 9.10.0.
7082  3     Integrate hints preferences option in the vscode extension
7081  4     Add open containing folder action.
7080  13    Fix detection of support for generation session beans from entity classes and support jakarta package names
7077  3     Fix: Settings persistence does not work for inner-class hints
7076  9     Replace usage of package `org.codehaus.plexus.util.IOUtil` with Java native methods.
7075  1     Escape java hint fix String for html and fill in multi variables.
7070  10    New file created by copy/paste in git repo ignores commit exclusion flag
7063  9     Improve priming from LSP client
7062  26    Cleanup HashMap raw type warnings..
7055  1     Adding support for Wildfly 31
7053  1687  Code Cleanup/Deprecation fixes: Class#newInstance, underscore identifier, better temp files, avoid toUpper/LowerCase and more
7034  14    Adjusting some license texts.
7032  8     Add support for GlassFish 7.0.12
7030  3     Fixed concurrency issues in GradleDaemonExecutor
7024  15    Gradle Project shall use the Java from the tooling not runtime.
7020  38    Final changes for JakartaEE adjustments
7012  1     Improved Toolbar overflow impl.
7004  9     Update guava from 32.1.2-jre to 33.0.0-jre
6999  2     JDK 21 support to Payara Platform tools v6.x in Apache NetBeans IDE
6988  223   Add support for Jakarta EE 11
6985  4     Enable code completion in JSF and JSP pages in Jakarta based projects
6984  15    Enable Servlet/Filter/Listener generation for Jakarta based projects
6892  28    Embedded Chromium Brower into NetBeans
6866  5     Allow user to manipulate Truffle breakpoints
6844  71    [Rust] Rust workspaces support.
6834  11    Added go to test ability for test/tested class in lsp server
6829  12    Support for multiple NetBeans Gradle Tooling

thanks for review!