-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate hints preferences option in the vscode extension #7082
Conversation
@mbien Can someone please review this PR? |
@Achal1607 I don't know much about LSP, but I pinged some who do |
@Achal1607 would it be possible to fix the conflict ? Sorry for delay |
Signed-off-by: Achal Talati <achal.talati@oracle.com>
cf610aa
to
89d8dbb
Compare
@ebarboni resolved merge conflicts |
I haven't done any change related to PHP, so I am not sure why it's tests are failing. So, can someone trigger again that test pls? |
Tests failure error:
|
@sdedic @dbalek please don't forget to merge once reviewed and when it fits the timeline since @Achal1607 doesn't have commit rights. Other recent incidents showed that leaving PRs open post-review for a long time can cause issues post merge, esp when the tests haven't run for months (which isn't the case here but lets not forget about reviewed PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
I had earlier raised a PR for Computing hints based on custom preferences #6760, but forgot to push the changes to integrate it with vscode extension.
So, here is the patch for that.