Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate hints preferences option in the vscode extension #7082

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Achal1607
Copy link
Contributor

@Achal1607 Achal1607 commented Feb 19, 2024

I had earlier raised a PR for Computing hints based on custom preferences #6760, but forgot to push the changes to integrate it with vscode extension.
So, here is the patch for that.

@mbien mbien added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Feb 19, 2024
@apache apache locked and limited conversation to collaborators Feb 19, 2024
@apache apache unlocked this conversation Feb 19, 2024
@Achal1607
Copy link
Contributor Author

@mbien Can someone please review this PR?
It is a small change so it should be quick IMO

@mbien
Copy link
Member

mbien commented Feb 27, 2024

@Achal1607 I don't know much about LSP, but I pinged some who do

@mbien mbien added this to the NB22 milestone Feb 27, 2024
@ebarboni
Copy link
Contributor

@Achal1607 would it be possible to fix the conflict ? Sorry for delay

Signed-off-by: Achal Talati <achal.talati@oracle.com>
@Achal1607
Copy link
Contributor Author

@ebarboni resolved merge conflicts

@Achal1607
Copy link
Contributor Author

I haven't done any change related to PHP, so I am not sure why it's tests are failing. So, can someone trigger again that test pls?

@Achal1607
Copy link
Contributor Author

Achal1607 commented Apr 15, 2024

Tests failure error:

Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: build
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

@mbien
Copy link
Member

mbien commented Apr 15, 2024

@sdedic @dbalek please don't forget to merge once reviewed and when it fits the timeline since @Achal1607 doesn't have commit rights.

Other recent incidents showed that leaving PRs open post-review for a long time can cause issues post merge, esp when the tests haven't run for months (which isn't the case here but lets not forget about reviewed PRs).

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@lahodaj lahodaj merged commit e6f0f68 into apache:master Apr 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants