Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring pom.xml as well when renaming class inside editor #7104

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Achal1607
Copy link
Contributor

@Achal1607 Achal1607 commented Feb 24, 2024

When we currently rename any class inside the vscode editor, it refactors the file name, class name and other places where the class name is used, but it doesn't update the pom.xml in a maven project. So, this PR tries to address that issue.

For more info : oracle/javavscode#30

@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests labels Feb 24, 2024
@mbien mbien added this to the NB22 milestone Feb 24, 2024
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Feb 24, 2024
@apache apache locked and limited conversation to collaborators Feb 24, 2024
@apache apache unlocked this conversation Feb 24, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good - I noticed this issue too, thanks!

pom properties could also show up in profiles etc, but I believe it is sufficient to cover the most common case, since that is also what NB generates - this is fine IMO.

Signed-off-by: Achal Talati <achal.talati@oracle.com>
@mbien
Copy link
Member

mbien commented Feb 27, 2024

ran a quick test and it worked great, thanks! merging.

@mbien mbien merged commit 4460a37 into apache:master Feb 27, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants