Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix welcome page after config import. #7141

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

mbien
Copy link
Member

@mbien mbien commented Mar 8, 2024

having the welcome page enabled while importing the config broke the reload

  • RSSFeed tried to load an empty cache file if the preferences had a modification date which caused SaxExceptions
  • this should be more robust now
    • cache logic doesn't create empty files anymore
    • networking doesn't use the modification time field if the cache isn't there
    • cache reset on exception should work now

fixes #4288

 - RSSFeed tried to load an empty cache file if the preferences had a
   modification date which caused SaxExceptions
 - this should be more robust now
   - cache logic doesn't create empty files anymore
   - networking doesn't use the modification time field if the cache
     isn't there
   - cache reset on exception should work now
@mbien mbien added UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Mar 8, 2024
@mbien mbien added this to the NB22 milestone Mar 8, 2024
@mbien mbien linked an issue Mar 8, 2024 that may be closed by this pull request
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane.

@mbien mbien merged commit 66fb629 into apache:master Mar 10, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's New fails to load
2 participants