Fix filtering of delete action on Favorites root nodes. #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes filtering out of the delete action on Favorite root nodes.
A discussion with @mbien elsewhere mentioned it would be good if the delete action wasn't available in the popup menu. Turns out that filtering used to be in there but no longer works. The type of the action is now
GeneralAction$DelegateActionbut we can also check if thekeyis"delete". Kept old check in case it's used anywhere. The placement of theRemove from Favoritesaction is also in the "wrong" place for the same reason, but I think it's better at the bottom anyway.