Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Java Sources from GoLang grammars pre-compile #7189

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

lkishalmi
Copy link
Contributor

This one is the same as #7186, for the GoLang Lexer/Parser.

FYI: Ith seems there is a newer Grammar available on ANTLR site. I'm going to add a separate PR for that upgrade.

This one is related to #7180

@lkishalmi lkishalmi added the Go Go Language label Mar 25, 2024
@lkishalmi lkishalmi added this to the NB22 milestone Mar 25, 2024
@lkishalmi
Copy link
Contributor Author

@matthiasblaesing What do you think, since we do not add the sources to the repo, do we still need to add the Apache License header generation to the grammars? I mean this step.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@lkishalmi lkishalmi merged commit ab9751f into apache:master Mar 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go Go Language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants