JS: Handle meta-properties new.target and import.meta and improve code completion with newlines and comments #7211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get (already supported) Parsing was modified to report 'new.target' as an AccessNode on an IdentNode 'new' with property 'target'. 'import.meta' is modelled identically.
… and import.meta The JS parser reports new.target as an AccessNode for the property "target" on the IdentNode "new". The parser has no KeyWord Node, else that would be the best choice. The lexer lexes new.target as three tokens: - Keyword "new" - Operator "." - Identifier "target"
matthiasblaesing
added
JavaScript
matthiasblaesing
force-pushed
the
js-import-meta
branch
from
4a4a2ce
to
79f2643
Compare
Both new.target and import.meta are declared as special properties with special semantic as they are properties on keywords. The approach taken here is to declare a helper object "metaproperties", declare the "new" and "import" properties and their children there. After parsing the properties are relocated from metaproperties into the global object, where they will be picked up by the JsCompletion.
…dded comments and new lines
matthiasblaesing
force-pushed
the
js-import-meta
branch
from
79f2643
to
9766a62
Compare
|
This was successfully tested - so lets get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS currently provides two meta-properties:
new.targetimport.metanew.targetwas already partially supported and lexed as a single identifier. This makes it hard to support embedded comments or new lines. MDN describes both as properties as:The lexer lexes
import.metaandnew.targetas three tokens:neworimport.targetormetaThe parser will handle it slightly different and create an
AccessNodewith the property nametargetorimporton an IdentNodeneworimport.In addition the handling of new lines and comments in expression chains (
obj.prop1.prop2) was improved.Closes: #5919