Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle Tooling API to 8.7 #7215

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

lkishalmi
Copy link
Contributor

Let's have this updated before NB22.

@lkishalmi lkishalmi added the Gradle [ci] enable "build tools" tests label Mar 31, 2024
@lkishalmi lkishalmi added this to the NB22 milestone Mar 31, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me

extide/gradle/apichanges.xml Show resolved Hide resolved
Comment on lines 103 to +106
GradleVersion.version("8.5"), // JDK-21
};

private static final GradleVersion LAST_KNOWN_GRADLE = GradleVersion.version("8.6"); //NOI18N
private static final GradleVersion LAST_KNOWN_GRADLE = GradleVersion.version("8.7"); //NOI18N
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like groovy is holding up gradle again:
https://docs.gradle.org/8.7/release-notes.html#java-22

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn! Why did no one tell groovy that this should not work:

matthias@enterprise:~/Downloads$ ~/bin/groovy-4/bin/groovy -v
Groovy Version: 4.0.20 JVM: 22 Vendor: Oracle Corporation OS: Linux
matthias@enterprise:~/Downloads$ ~/bin/groovy-4/bin/groovy -e 'print "Hello World\n"'
Hello World
matthias@enterprise:~/Downloads$

http://groovy-lang.org/changelogs/changelog-4.0.16.html references support for JDK 22. That release was created about 4 months ago.

I think this might be a bit more involved, than "groovy does not support JDK 22", maybe it is "we did not manage to integrate the groovy version that support JDK 22".

Copy link
Member

@mbien mbien Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the release notes are a bit oversimplified which caused issues in past since they were not clear what is supposed to work and what doesn't work on current jdks.

gradle/gradle#26162 this issue tracks JDK 22 progress. Groovy isn't the only item holding them back.

@lkishalmi lkishalmi merged commit 9bc649b into apache:master Apr 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants