Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsfVersion might not be known, so null case must be handled #7216

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

matthiasblaesing
Copy link
Contributor

Closes: #7213

@matthiasblaesing matthiasblaesing added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Mar 31, 2024
@matthiasblaesing matthiasblaesing added this to the NB22 milestone Mar 31, 2024
@BetoValle
Copy link

Hi, Matthias

"I thought" that if I downloaded the compressed netbeans from "artifacts", unzipped it in a temporary folder I could check this update they made. I did this and I can't load netBeans because it displays the message:
"Cannot run on older versions of Java than Java 17.
Please install Java 17 or newer or use --jdkhome
“switch to point to its installation directory."

See that I use java11! in the netbeans.conf file (in this temporary folder where I installed it to test) I informed
the correct folder for the --jdkhome parameter
but for some other reason he doesn't obey!

I forced netbeans to load in the line command with the parameter
--jdkhome (+ the correct folder) and it didn't work either because it displays the same message above!

Therefore, as I have no knowledge of what could be happening with the netBeans load that they modified, I have no way of testing it. OR otherwise could you give some instructions.

Thanks

@ebarboni
Copy link
Contributor

ebarboni commented Apr 8, 2024

LGTM

@matthiasblaesing
Copy link
Contributor Author

@ebarboni thanks for checking. This was tested successfully. The problem of the reporter were caused by a bit surprising auto-update behavior coupled with a prior merged PR.

@matthiasblaesing matthiasblaesing merged commit d1fac36 into apache:master Apr 8, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job
Projects
Development

Successfully merging this pull request may close these issues.

nullpointerexception / JspJsfELPlugin
3 participants