Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-1074] Module Review j2eeserver #723

Merged

Conversation

thilina01
Copy link
Member

added 2 templates and 23 graphic files to licenseinfo.xml

junichi11
junichi11 previously approved these changes Aug 20, 2018
Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


<licenseinfo>
<fileset>
<file>src/org/netbeans/modules/j2ee/deployment/impl/server-string.dtd</file>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #722 applies here (both DTDs can hold the ALv2 header).

@junichi11 junichi11 dismissed their stale review August 20, 2018 16:48

Please look at Matthias' comment.

added license headers to 2 dtd files
added 23 graphic files to licenseinfo.xml
@thilina01 thilina01 force-pushed the netbeans-1074-2nd-review-j2eeserver branch from 2d1586c to 64f9913 Compare August 21, 2018 06:47
@thilina01
Copy link
Member Author

@junichi11 @matthiasblaesing Please review the changes. Thanks. :)

@matthiasblaesing
Copy link
Contributor

Thank you!

@matthiasblaesing matthiasblaesing merged commit e87703f into apache:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants