Deconflict some layer registration positions #7235
Conversation
mbien
added
Java
| @@ -50,7 +50,7 @@ protected void index(Iterable<? extends Indexable> files, Context context) { | |||
| } | |||
|
|
|||
|
|
|||
| @MimeRegistration(mimeType="text/x-java", service=CustomIndexerFactory.class, position=1_000) | |||
| @MimeRegistration(mimeType="text/x-java", service=CustomIndexerFactory.class, position=1_100) | |||
There was a problem hiding this comment.
I see this error for the CompilerOptionsIndexer:
WARNING [org.openide.filesystems.Ordering]: Not all children in / marked with the position attribute: [org-netbeans-modules-refactoring-java-plugins-InstantRefactoringPerformer$UndoableWrapper.instance, org-netbeans-modules-testng-ui-actions-TestClassInfoTask$TestNGComputeTestMethodsImpl.instance, org-netbeans-modules-java-hints-spiimpl-hints-HintsTask$SuggestionsPositionRefresherHelper.instance, org-netbeans-modules-java-hints-spiimpl-options-HintsSettings$GlobalSettingsProvider.instance, org-netbeans-modules-editor-java-JavaKit$JavaTypedTextInterceptor$Factory.instance, org-netbeans-modules-micronaut-MicronautExpressionLanguageTokenId$Factory.instance, org-netbeans-modules-java-hints-declarative-debugging-EvaluationSpanTask$FactoryImpl.instance, org-netbeans-modules-refactoring-java-ui-HighlightsLayerFactory.instance, org-netbeans-modules-java-editor-codegen-RemoveSurroundingCodePanel$UnwrapCodeHighlightsLayerFactory.instance, EditorKit.instance, org-netbeans-modules-java-navigation-BreadCrumbsScanningTask$Factory.instance, org-netbeans-modules-java-hints-infrastructure-JavaErrorProvider.instance, org-netbeans-modules-java-hints-infrastructure-ErrorHintsFactory.instance, org-netbeans-modules-junit-ui-actions-TestClassInfoTask$JUnitComputeTestMethodsImpl.instance, org-netbeans-modules-java-editor-semantic-SemanticHighlighterFactory.instance, org-netbeans-modules-java-hints-infrastructure-EmbeddedLazyHintComputation$FactoryImpl.instance, Reformatter.instance, org-netbeans-modules-java-source-indexing-JavaCustomIndexer$Factory-register.instance, org-netbeans-modules-java-hints-infrastructure-ErrorPositionRefresherHelper.instance, org-netbeans-modules-java-hints-introduce-IntroduceHint$HLFImpl.instance, org-netbeans-modules-editor-htmlui-JSEmbeddingProvider$Factory.instance, org-netbeans-modules-editor-java-CamelCaseOperations$JavaCamelCaseInterceptor$JavaFactory.instance, org-netbeans-modules-java-editor-whitelist-WhiteListCheckTask$Factory.instance, org-netbeans-modules-gsf-codecoverage-CoverageHighlightsLayerFactory.instance, SourcePathCheck.instance, org-netbeans-modules-editor-java-JavaKit$JavaDeletedTextInterceptor$Factory.instance, org-netbeans-modules-javadoc-highlighting-Factory.instance, org-netbeans-modules-java-editor-fold-ResourceStringFoldProvider.instance, AutoIndenter.instance, org-netbeans-modules-java-guards-JavaGuardedSections.instance, org-netbeans-modules-whitelist-index-WhiteListIndexerPlugin$Factory.instance, org-netbeans-modules-java-debug-HighlightsLayerFactoryImpl.instance, CopyResourcesIndexer.instance, org-netbeans-modules-refactoring-java-plugins-InstantRefactoringPerformer$RenameDeletedTextInterceptor$Factory.instance, org-netbeans-modules-java-source-parsing-JavacParserFactory.instance, org-netbeans-modules-java-editor-semantic-HighlightsLayerFactoryImpl.instance, org-netbeans-modules-java-editor-rename-InstantRenamePerformer$RenameDeletedTextInterceptor$Factory.instance, org-netbeans-modules-java-editor-overridden-ComputeAnnotations$FactoryImpl.instance, org.netbeans.spi.editor.highlighting.HighlightsLayerFactory.instance, Reindenter.instance, org-netbeans-modules-java-editor-semantic-MarkOccurrencesHighlighterFactory.instance, org-netbeans-modules-debugger-jpda-projectsui-HighlightsLayerFactoryImpl.instance, org-netbeans-modules-micronaut-symbol-MicronautSymbolErrorProvider.instance, org-netbeans-modules-java-source-parsing-VanillaPartialReparser$VerifyPartialReparse$FactoryImpl.instance, org-netbeans-modules-java-hints-spiimpl-hints-HintsTask$HintPositionRefresherHelper.instance, org-netbeans-modules-refactoring-java-callhierarchy-LspCallHierarchyProvider.instance, org-netbeans-modules-micronaut-symbol-MicronautSymbolFinder$Factory.instance, language.instance, org-netbeans-modules-editor-java-JavaKit$JavaTypedBreakInterceptor$JavaFactory.instance, org-netbeans-modules-java-hints-introduce-PositionRefresherHelperImpl.instance, org-netbeans-modules-profiler-nbimpl-providers-JavaProfilerSourceImpl.instance, org-netbeans-modules-java-hints-spiimpl-JavaHintsPositionRefresher.instance, org-netbeans-modules-lsp-client-bindings-SemanticHighlight$HighlightsLayerFactoryImpl.instance, org-netbeans-modules-editor-fold-ui-FoldingEditorSupport$F.instance, org-netbeans-modules-java-source-indexing-JavaBinaryIndexer$Factory-register.instance, org-netbeans-lib-editor-codetemplates-textsync-TextRegionManager$Highlighting$HLFactory.instance, org-netbeans-modules-lsp-client-bindings-MarkOccurrences$HighlightsLayerFactoryImpl.instance, org-netbeans-modules-lsp-client-bindings-CustomIndexerImpl$FactoryImpl.instance, org-netbeans-modules-merge-builtin-visualizer-MergeHighlightsLayerFactory.instance, org-netbeans-modules-csl-hints-infrastructure-SelectionHintsTaskFactory.instance, org-netbeans-modules-editor-hints-lsp-HintsDiagnosticsProvider.instance, org-netbeans-modules-java-hints-infrastructure-EmbeddedHintsCollector$Factory.instance, org-netbeans-modules-csl-core-CslCamelCaseInterceptor$Factory.instance, org-netbeans-modules-csl-editor-overridden-ComputeAnnotations$FactoryImpl.instance, org-netbeans-modules-spellchecker-SpellcheckerHighlightLayerFactory.instance, org-netbeans-modules-editor-impl-DocumentFactoryImpl.instance, org-netbeans-modules-diff-builtin-visualizer-editable-DiffHighlightsLayerFactory.instance, org-netbeans-modules-csl-editor-fold-GsfFoldManagerTaskFactory.instance, org-netbeans-modules-textmate-lexer-SyntaxHighlighting$FactoryImpl.instance, org-netbeans-modules-editor-impl-highlighting-HLFactory.instance, org-netbeans-modules-editor-hints-HighlightsLayerFactoryImpl.instance, org-netbeans-modules-editor-bracesmatching-BracesMatchHighlighting$Factory.instance, org-netbeans-lib-editor-hyperlink-HyperlinkOperation$HighlightFactoryImpl.instance, org-netbeans-modules-javascript2-editor-embedding-JsEmbeddingProvider$Factory.instance, org-netbeans-modules-csl-editor-semantic-MarkOccurrencesHighlighterFactory.instance, org-netbeans-modules-editor-lib2-highlighting-Factory.instance, org-netbeans-modules-editor-search-TextSearchHighlighting$FactoryImpl.instance, org-netbeans-modules-csl-hints-infrastructure-HintsTaskFactory.instance, org-netbeans-modules-refactoring-spi-impl-UndoableWrapper.instance, COSSynchronizingIndexer.instance, org-netbeans-modules-java-lsp-server-protocol-Server$LSPServerTelemetryFactory-getDefault.instance, org-netbeans-modules-gsf-testrunner-ui-TestMethodFinderImpl$Factory.instance, org-netbeans-modules-csl-hints-GsfHintsFactory.instance, org-netbeans-modules-csl-navigation-BreadCrumbsTask$TaskFactoryImpl.instance, org-netbeans-modules-editor-url-HighlightURLs$FactoryImpl.instance, org-netbeans-modules-web-jsf-editor-index-JsfBinaryIndexer.instance, org-netbeans-modules-web-jsf-editor-index-JsfCustomIndexer$Factory.instance, org-netbeans-modules-tasklist-impl-TaskIndexerFactory.instance, org-netbeans-modules-csl-hints-infrastructure-SuggestionsTaskFactory.instance, org-netbeans-modules-jumpto-file-FileIndexer$Factory.instance, org-netbeans-modules-csl-navigation-CaretListeningFactory.instance, org-netbeans-modules-csl-navigation-ClassMemberNavigatorSourceFactory.instance, org-netbeans-modules-csl-editor-semantic-SemanticHighlighterFactory.instance, org-netbeans-modules-spring-beans-index-SpringBinaryIndexer.instance], but some are: [org-netbeans-modules-editor-java-JavaStructureProvider.instance, org-netbeans-modules-java-file-launcher-indexer-CompilerOptionsIndexer$FactoryImpl.instance, org-netbeans-modules-micronaut-symbol-MicronautStructureProvider.instance]
This looks like a different problem - we have no duplicates, but a mixed case.
There was a problem hiding this comment.
this looks like a warning which would also happen without this change, just that the list on the end of the log line would have one item less:
but some are: [org-netbeans-modules-editor-java-JavaStructureProvider.instance, org-netbeans-modules-java-file-launcher-indexer-CompilerOptionsIndexer$FactoryImpl.instance, org-netbeans-modules-micronaut-symbol-MicronautStructureProvider.instance]
There was a problem hiding this comment.
I do not see the conflict, but anyway, I also see no problem in the change.
There was a problem hiding this comment.
you mean you can't reproduce this warning?
WARNING [org.openide.filesystems.Ordering]: Found same position 1,000 for both org-netbeans-modules-micronaut-symbol-MicronautStructureProvider.instance and org-netbeans-modules-java-file-launcher-indexer-CompilerOptionsIndexer$FactoryImpl.instance
I have to check tomorrow, but I think one of them was triggered via right click on a file or something like that - I forgot.
There was a problem hiding this comment.
Now I see it, sorry for the noise.
|
noticed another warning while testing a different PR: going to update that one too, probably give jakarta higher priority (smaller number) since it is now the preferred version. |
- resolves four org.openide.filesystems.Ordering warnings - the older entry is kept, the more recent entry is bumped to a free position
mbien
force-pushed
the
resolve-position-conflicts
branch
from
9261205
to
3c87d8c
Compare
org.openide.filesystems.Orderingwarningsfrom log: