Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add org.netbeans.libs.nbjavac as recommends for java.source.base. #7334

Merged
merged 1 commit into from Apr 26, 2024

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Apr 25, 2024

Potential quick fix for #7091 caused by regression in #6743 . More detail at #7091 (comment)

Do not merge if there's a better suggestion from @lahodaj or others on how to handle this issue.

Fixes GH7091 caused by regression in GH6743.
@neilcsmith-net neilcsmith-net added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Apr 25, 2024
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the trouble. I'd say, lets readd the dependency as you suggest. You are right that's likely to break the other usecase, but it does not affect NetBeans artifacts as such, and I'll try to find a way to support all the usecases separately.

Thanks for working on this!

@neilcsmith-net
Copy link
Member Author

neilcsmith-net commented Apr 26, 2024

Thanks @lahodaj

For NB23 we should look at why enabling extide modules is triggering parts of Java cluster to load. That could allow for this to be removed again. I have a feeling may be related to profiler action references in the Gradle modules???

I think is also the cause of the nb-javac missing dialog reported in https://lists.apache.org/thread/xrsnmjk5r7h0rp7y5n76gw6bfd6k71zp I saw that coming up while debugging this issue on JDK 17.

@neilcsmith-net neilcsmith-net removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Apr 26, 2024
@ebarboni ebarboni added this to the NB22 milestone Apr 26, 2024
Copy link
Contributor

@ebarboni ebarboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge then

@ebarboni ebarboni merged commit 5889acc into apache:delivery Apr 26, 2024
37 checks passed
@mbien mbien linked an issue Apr 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
3 participants