Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing schemas for Jakarta Server Pages Tag Library (JSTL) #7340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing schemas for Jakarta Server Pages Tag Library (JSTL) #7340

wants to merge 1 commit into from

Conversation

pepness
Copy link
Member

@pepness pepness commented Apr 27, 2024

NetBeans web.core module notes:

  • Implement CatalogDescriptor2 instead of deprecated CatalogDescriptor
  • Add JSTL schema version 3.0 for Jakarta 9
  • Add JSTL schema version 3.1 for Jakarta 10
  • Add JSTL schema version 4.0 for Jakarta 11

NetBeans Testing:

  • Verify successful execution of libraries and licenses Ant test
  • Verify successful execution of Verify Sigtests
  • Verify successful execution of unit tests for module web.core
  • Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
  • Successfully create a web app and verify that JSTL works.

Screenshot from 2024-04-26 18-48-21

@pepness
Add missing schemas for Jakarta Server Pages Tag Library
9542dfa 
- Implement CatalogDescriptor2 instead of deprecated CatalogDescriptor
- Add JSTL schema version 3.0 for jakarta 9
- Add JSTL schema version 3.1 for jakarta 10
- Add JSTL schema version 4.0 for jakarta 11
@pepness pepness added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Apr 27, 2024
@pepness pepness added this to the NB23 milestone Apr 27, 2024
@pepness pepness self-assigned this Apr 27, 2024
matthiasblaesing
matthiasblaesing approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

@pepness pepness

Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pepness @matthiasblaesing