Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MavenVersionSettings fallback versions. #7357

Merged
merged 1 commit into from
May 7, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented May 3, 2024

bump some defaults

@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests labels May 3, 2024
@mbien mbien added this to the NB22 milestone May 4, 2024
@mbien mbien marked this pull request as ready for review May 4, 2024 00:34
@vieiro
Copy link
Contributor

vieiro commented May 6, 2024

Looks ok to me.

I was wondering if we should update the Releasing Apache NetBeans Maven Utilities and/or the Apache NetBeans Release README with this PR as a template?

@mbien
Copy link
Member Author

mbien commented May 6, 2024

I was wondering if we should update the Releasing Apache NetBeans Maven Utilities and/or the Apache NetBeans Release README with this PR as a template?

@vieiro well, this PR here isn't strictly needed since versions would be just the defaults if the index is not (yet) available or disabled by the user. I am also not sure if this is even a good idea, since this could cause issues during testing. Both nb-maven-plugin 14.1 and NB 22 are not released yet - if you don't have them in your local repo some wizards will likely fail.

I never updated a version to a not yet released lib so far.

@vieiro
Copy link
Contributor

vieiro commented May 7, 2024

@vieiro well, this PR here isn't strictly needed since versions would be just the defaults if the index is not (yet) available or disabled by the user. I am also not sure if this is even a good idea, since this could cause issues during testing. Both nb-maven-plugin 14.1 and NB 22 are not released yet - if you don't have them in your local repo some wizards will likely fail.

I never updated a version to a not yet released lib so far.

Exactly! That's why I was asking. I think we could set up a local repo with artifacts and then re-test things, but that would complicate the release process, right?

@mbien mbien added the ci:all-tests [ci] enable all tests label May 7, 2024
@mbien
Copy link
Member Author

mbien commented May 7, 2024

running tests again with everything enabled

@apache apache locked and limited conversation to collaborators May 7, 2024
@apache apache unlocked this conversation May 7, 2024
@neilcsmith-net
Copy link
Member

Definitely don't update the release readme to follow this! If there's a decision to always have the fallback be the in use release, then it should be templated in like every other use of the current version in the build. The JSON metainfo already has this value.

No argument against this as is, depending on @ebarboni take.

@ebarboni
Copy link
Contributor

ebarboni commented May 7, 2024

the only issue could be mistake on populating artefacts for RELEASE220 happens only once in history :D

@mbien mbien removed the ci:all-tests [ci] enable all tests label May 7, 2024
@mbien
Copy link
Member Author

mbien commented May 7, 2024

.. then it should be templated in like every other use of the current version in the build

@neilcsmith-net in worst case we switch all version strings to functions like in #6213 :P -> Chronographic Versioning

@ebarboni ebarboni merged commit 09cb41c into apache:delivery May 7, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants