-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MavenVersionSettings fallback versions. #7357
Conversation
Looks ok to me. I was wondering if we should update the Releasing Apache NetBeans Maven Utilities and/or the Apache NetBeans Release README with this PR as a template? |
@vieiro well, this PR here isn't strictly needed since versions would be just the defaults if the index is not (yet) available or disabled by the user. I am also not sure if this is even a good idea, since this could cause issues during testing. Both nb-maven-plugin 14.1 and NB 22 are not released yet - if you don't have them in your local repo some wizards will likely fail. I never updated a version to a not yet released lib so far. |
Exactly! That's why I was asking. I think we could set up a local repo with artifacts and then re-test things, but that would complicate the release process, right? |
running tests again with everything enabled |
Definitely don't update the release readme to follow this! If there's a decision to always have the fallback be the in use release, then it should be templated in like every other use of the current version in the build. The JSON metainfo already has this value. No argument against this as is, depending on @ebarboni take. |
the only issue could be mistake on populating artefacts for RELEASE220 happens only once in history :D |
@neilcsmith-net in worst case we switch all version strings to functions like in #6213 :P -> Chronographic Versioning |
bump some defaults