Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TreeUtilities.pathFor for synthetic 'value=' in annotations also for start position #7378

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix TreeUtilities.pathFor for synthetic 'value=' in annotations also for start position #7378

merged 1 commit into from
May 14, 2024

Conversation

matthiasblaesing
Copy link
Contributor

Closes: #4186

@matthiasblaesing matthiasblaesing added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels May 13, 2024
@apache apache locked and limited conversation to collaborators May 13, 2024
@apache apache unlocked this conversation May 13, 2024
@mbien mbien added this to the NB22 milestone May 13, 2024
mbien
mbien approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. I had that issue on my todo list but never got to it so far :)

@mbien mbien linked an issue May 14, 2024 that may be closed by this pull request
Navigate to source does not work for annotation with default value of type Class #4186
Closed
@matthiasblaesing matthiasblaesing mentioned this pull request May 14, 2024
Closed
@matthiasblaesing
Copy link
Contributor Author

@mbien thanks for the quick review. I was triggered by the recent comment and that reminded me, that this behaviour annoyed the hell out of me. So I had a quick look. As @lahodaj already had fixes for end position -1 in place, that looked like the right place to have a closer look. In the end the position reported by javac was off by six (if I remember correctly) characters and that nicely matches the width of value=.

@Saljack
Copy link

Saljack commented May 14, 2024

I confirm that everything works like a charm.

@ebarboni ebarboni merged commit 26b10a0 into apache:delivery May 14, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
NB22
Development

Successfully merging this pull request may close these issues.

Navigate to source does not work for annotation with default value of type Class
4 participants
@matthiasblaesing @Saljack @mbien @ebarboni