Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the status bar Notification bubble sharp on HiDPI/Retina screens #7473

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Make the status bar Notification bubble sharp on HiDPI/Retina screens #7473

merged 1 commit into from
Jun 18, 2024

Conversation

eirikbakke
Copy link
Contributor

This patch, in combination with #7463, makes the notification bubble in the status bar look sharp on Retina/HiDPI screens.

image

@eirikbakke eirikbakke added UI User Interface Platform [ci] enable platform tests (platform/*) labels Jun 13, 2024
@apache apache locked as off-topic and limited conversation to collaborators Jun 13, 2024
@apache apache unlocked this conversation Jun 13, 2024
matthiasblaesing
matthiasblaesing approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but change looks sane and makes sense to me. The appearance also improves on non-HIDPI display.

@eirikbakke eirikbakke merged commit bfa14ae into apache:master Jun 18, 2024
64 of 70 checks passed
@eirikbakke
Copy link
Contributor Author

Thanks for reviewing! Merged.

@mbien mbien added this to the NB23 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
Platform [ci] enable platform tests (platform/*) UI User Interface
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eirikbakke @matthiasblaesing @mbien