Avoid a missing JCheckBoxItem checkmark for boolean actions without an icon #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checkmark rather than using an empty icon.
eirikbakke
added
Platform
mbien
approved these changes
Jul 25, 2024
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In menu bars, a boolean action will become a JCheckBoxMenuItem which can work with or without a custom icon. If the action has no icon of its own, the LAF will provide a checkmark icon instead, which is good. But due to a bug in org.openide.awt.Actions, a blank icon is used instead. Fix this so the checkmark properly appears in this case.
(Mostly relevant for NetBeans Platform apps; I haven't seen this case appear in the NetBeans IDE.)