Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global maven goal presets #7537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbien
Copy link
Member

@mbien mbien commented Jul 2, 2024

  • add mvnw updater and a few maveniverse toolbox diagnostic goals as global preset
  • add right click menu actions which lead to the global and project rule editors for easy add/edit/remove
  • some layout adjustments to both global and custom goal windows so that they resize nicely
  • minor language level cleanup

image

"Edit Global Goals" (new) will open the (already existing) window:
image

(also accessible from maven execution options)

note:
I reverted a few things to not change too much at once. What I originally planned was to combine the global and per-project goal editor windows and I wanted to move the global editor panel to a card in the main maven options. However, the problem is that the two windows and the tools->options windows have different ways how to handle persistence, so this would have been too much at once. Still something we can do at some point.

@mbien mbien added Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 2, 2024
@mbien mbien added this to the NB23 milestone Jul 2, 2024
@neilcsmith-net
Copy link
Member

Looks good!

Ideally would have a link to Edit Project Goals that opens the right section of the project properties, between the Other Goals... and Edit Global Goals... links. Possibly another separator between Other Goals... and the edit actions to emphasize execution vs edit?

 - add mvnw updater and a few maveniverse toolbox diagnostic
   goals as global preset
 - add right click menu actions which lead to the global and project
   rule editors for easy add/edit/remove
 - some layout adjustments to both global and custom goal windows so
   that they resize nicely
 - minor language level cleanup
@mbien
Copy link
Member Author

mbien commented Jul 3, 2024

@neilcsmith-net updated the screenshot, let me know what you think

@neilcsmith-net
Copy link
Member

Thanks! Think that works and a good change for NB23.

We could perhaps (in future!) standardize some of the terminology here. We use Goals and Actions in different places, and neither entirely overlaps with Maven's concept of Goal.

@mbien
Copy link
Member Author

mbien commented Jul 5, 2024

we would probably have to call it "action" everywhere to be technically correct, since compile is a phase and compile:compile a goal which happens to be in that phase. The action presets work for both, phases and goals.

Its just that goal is the more familiar term most likely, so if it happens to support phases it is probably ok to call the menu entry point "Edit Goals..."?

I would probably leave it as is for now tbh but I would also have no problem to change it to "Edit Actions...".

@mbien mbien requested a review from neilcsmith-net July 8, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants