New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFI-109: Add ExecuteProcess #13
Conversation
Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed a test of this converting from a template made in NiFi and tested it with various commands. Overall looks good. I do think we should change that one variable name for consistency, but otherwise looks good to go!
Thanks @benqiu2016!
static const std::string ProcessorName; | ||
//! Supported Properties | ||
static Property Command; | ||
static Property CommandArgument; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to update this to CommandArguments for consistency.
@apiri Address the above review comments. Thanks for the review. |
@benqiu2016 Looks good here! Will merge in and thanks for the contribution. |
@benqiu2016 @apiri saw that this got committed to master. Unfortunately, I'm getting build errors that strcpy and strtok are not members of 'std'. Including some build environment info and the errors produced: http://pastebin.com/fW6MmJSy |
hey @randerzander would you mind please opening a ticket in JIRA to report this so we can track appropriately? https://issues.apache.org/jira/browse/MINIFI |
Will do. I assumed you would have considered it part of the original On Sep 29, 2016 9:21 AM, "Aldrin Piri" notifications@github.com wrote: hey @randerzander https://github.com/randerzander would you mind please — |
Thanks! Just makes it a little easier to cover as that one was closed out. Much appreciated. Was able to reproduce on a Linux environment. |
I have opened https://issues.apache.org/jira/browse/MINIFI-111 |
@randerzander Great, thanks! |
No description provided.