Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFI-109: Add ExecuteProcess #13

Closed
wants to merge 2 commits into from

Conversation

minifirocks
Copy link

No description provided.

@apiri apiri mentioned this pull request Sep 27, 2016
@apiri
Copy link
Member

apiri commented Sep 27, 2016

Reviewing

Copy link
Member

@apiri apiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed a test of this converting from a template made in NiFi and tested it with various commands. Overall looks good. I do think we should change that one variable name for consistency, but otherwise looks good to go!

Thanks @benqiu2016!

static const std::string ProcessorName;
//! Supported Properties
static Property Command;
static Property CommandArgument;
Copy link
Member

@apiri apiri Sep 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to update this to CommandArguments for consistency.

@minifirocks
Copy link
Author

@apiri Address the above review comments. Thanks for the review.

@apiri
Copy link
Member

apiri commented Sep 28, 2016

@benqiu2016 Looks good here! Will merge in and thanks for the contribution.

@asfgit asfgit closed this in a20d82c Sep 28, 2016
@randerzander
Copy link
Contributor

randerzander commented Sep 29, 2016

@benqiu2016 @apiri saw that this got committed to master.

Unfortunately, I'm getting build errors that strcpy and strtok are not members of 'std'. Including some build environment info and the errors produced: http://pastebin.com/fW6MmJSy

@apiri
Copy link
Member

apiri commented Sep 29, 2016

hey @randerzander would you mind please opening a ticket in JIRA to report this so we can track appropriately? https://issues.apache.org/jira/browse/MINIFI

@randerzander
Copy link
Contributor

Will do. I assumed you would have considered it part of the original
ExecuteProcess jira. Will reply here shortly

On Sep 29, 2016 9:21 AM, "Aldrin Piri" notifications@github.com wrote:

hey @randerzander https://github.com/randerzander would you mind please
opening a ticket in JIRA to report this so we can track appropriately?
https://issues.apache.org/jira/browse/MINIFI


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnU8hCdn8N9rKTH7vW6XStO8nDyKdtSks5qu7tFgaJpZM4KGzNJ
.

@apiri
Copy link
Member

apiri commented Sep 29, 2016

Thanks! Just makes it a little easier to cover as that one was closed out. Much appreciated. Was able to reproduce on a Linux environment.

@randerzander
Copy link
Contributor

@apiri
Copy link
Member

apiri commented Sep 29, 2016

@randerzander Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants