Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring #1461

Closed
wants to merge 5 commits into from

Conversation

lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Nov 28, 2022

This PR contains multiple changes and refactoring in the docker test environment:

  • Moved docker cluster specific classes to separate cluster directory under test/integration directory
  • minifi.properties and all additional configuration files are now mounted instead of building a separate image for every config
  • Added MinifiOptions to specify minifi deployment options like additional properties
  • New minifi test image is only built if additonal packages are needed (in case of SQL tests)
  • Removed inheritance hierarchy for DockerTestCluster
  • SingleNodeDockerCluster renamed to ContainerStore and only contains container deployment specific functionality
  • Extension specific checkers are extracted to separate checker classes
  • Docker communicator extracted for communicated with docker containers
  • Moved general container operations to Container base class
  • Flushing container logs in case of all assertion failures

https://issues.apache.org/jira/browse/MINIFICPP-1983


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez marked this pull request as ready for review November 29, 2022 08:30
@lordgamez lordgamez requested review from fgerlits and removed request for adam-markovics December 16, 2022 09:50
fgerlits pushed a commit to fgerlits/nifi-minifi-cpp that referenced this pull request Jan 24, 2023
Signed-off-by: Ferenc Gerlits <fgerlits@gmail.com>
This closes apache#1461
@fgerlits fgerlits closed this in 2dc5891 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants