Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines #1481

Conversation

fgerlits
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-1948

Add the component UUID to the end of lines logged by Processors and Controller Services. See an example in the Jira.

The feature is on by default, but can be turned off in minifi-log.properties.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink
Copy link
Member

This will be a great addition for our debugging capabilities. 👍

I've found some constructors where the passing of the uuid is still missing:
SSLContextService
ThreadManagementService
ListenSyslog
ConsumeWindowsEventLog
CollectorInitiatedSubscription
DeleteAzureDataLakeStorage
FetchAzureDataLakeStorage
StandardControllerServiceNode
StandardControllerServiceProvider
(maybe we could refactor some of these so the logger_ isnt initialized in the ctors but rather where it is declared)

also the tensorflow processors TFApplyGraph, TFConvertImageToTensor, TFExtractTopLabels (not sure if we want to do these since these are not really maintained anymore and they might not even compile anymore)

@fgerlits fgerlits force-pushed the MINIFICPP-1948_Include-Processor-UUID-in-logs branch from 7459ae6 to 19a655b Compare December 16, 2022 15:45
@fgerlits
Copy link
Contributor Author

I've found some constructors where the passing of the uuid is still missing

Thanks! I have added most of these, including tensorflow, in 19a655b.

I did not add UUID to the loggers of ThreadManagementService, StandardControllerServiceNode and StandardControllerServiceProvider, because these three are internal details of minifi, not real controller services that the user could add to the flow.

I would prefer not to add more refactoring to this PR, as it is too long already. We can do that later.

@martinzink
Copy link
Member

I've found some constructors where the passing of the uuid is still missing

Thanks! I have added most of these, including tensorflow, in 19a655b.

I did not add UUID to the loggers of ThreadManagementService, StandardControllerServiceNode and StandardControllerServiceProvider, because these three are internal details of minifi, not real controller services that the user could add to the flow.

I would prefer not to add more refactoring to this PR, as it is too long already. We can do that later.

Makes perfect sense, thanks :)

@fgerlits fgerlits force-pushed the MINIFICPP-1948_Include-Processor-UUID-in-logs branch 3 times, most recently from 841a5af to 8e2a3e2 Compare December 23, 2022 09:40
@fgerlits fgerlits force-pushed the MINIFICPP-1948_Include-Processor-UUID-in-logs branch from 8e2a3e2 to 3ed5ce4 Compare January 4, 2023 12:01
@fgerlits fgerlits force-pushed the MINIFICPP-1948_Include-Processor-UUID-in-logs branch from 3ed5ce4 to 53e1381 Compare January 9, 2023 12:57
lordgamez pushed a commit to lordgamez/nifi-minifi-cpp that referenced this pull request Jan 17, 2023
…rvice log lines

Signed-off-by: Gabor Gyimesi <gamezbird@gmail.com>

This closes apache#1481
@lordgamez lordgamez closed this in 30fdfb7 Jan 17, 2023
@fgerlits fgerlits deleted the MINIFICPP-1948_Include-Processor-UUID-in-logs branch January 19, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants