New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines #1481
MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines #1481
Conversation
This will be a great addition for our debugging capabilities. 👍 I've found some constructors where the passing of the uuid is still missing: also the tensorflow processors TFApplyGraph, TFConvertImageToTensor, TFExtractTopLabels (not sure if we want to do these since these are not really maintained anymore and they might not even compile anymore) |
7459ae6
to
19a655b
Compare
Thanks! I have added most of these, including tensorflow, in 19a655b. I did not add UUID to the loggers of I would prefer not to add more refactoring to this PR, as it is too long already. We can do that later. |
Makes perfect sense, thanks :) |
841a5af
to
8e2a3e2
Compare
8e2a3e2
to
3ed5ce4
Compare
…ngify it at the end
3ed5ce4
to
53e1381
Compare
…rvice log lines Signed-off-by: Gabor Gyimesi <gamezbird@gmail.com> This closes apache#1481
https://issues.apache.org/jira/browse/MINIFICPP-1948
Add the component UUID to the end of lines logged by Processors and Controller Services. See an example in the Jira.
The feature is on by default, but can be turned off in
minifi-log.properties
.Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.