Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2022 Add valid repository size metrics for all repositories #1490

Closed
wants to merge 10 commits into from

Conversation

lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Jan 11, 2023

Calculate and report repository sizes (memory for volatile, disk space for persistent repositories) on C2 and Prometheus interfaces. Additionally add max repository size metric where available.

https://issues.apache.org/jira/browse/MINIFICPP-2022

Depends on #1485 and #1489


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

extensions/rocksdb-repos/database/OpenRocksDb.cpp Outdated Show resolved Hide resolved
libminifi/include/core/Repository.h Outdated Show resolved Hide resolved
@lordgamez lordgamez changed the base branch from MINIFICPP-2028 to main March 10, 2023 10:48
@lordgamez lordgamez force-pushed the MINIFICPP-2022 branch 2 times, most recently from 1f7c8fc to 50e8581 Compare March 14, 2023 13:03
@lordgamez lordgamez force-pushed the MINIFICPP-2022 branch 2 times, most recently from eb0b4a8 to e5ff9b6 Compare March 21, 2023 16:15
METRICS.md Outdated Show resolved Hide resolved
libminifi/include/core/repository/FileSystemRepository.h Outdated Show resolved Hide resolved
libminifi/include/core/repository/FileSystemRepository.h Outdated Show resolved Hide resolved
@fgerlits fgerlits closed this in 93ef73a May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants