Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-1817 Use magic_enum library instead of SMART_ENUM #1609

Closed
wants to merge 4 commits into from

Conversation

lordgamez
Copy link
Contributor

@lordgamez lordgamez commented Jul 17, 2023

Note: Changed some processor properties using enum values to be required, as they are required by their use cases and also marked as required in NiFi.

Depends on #1589

https://issues.apache.org/jira/browse/MINIFICPP-1817


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez marked this pull request as ready for review July 18, 2023 07:32
@lordgamez lordgamez changed the base branch from MINIFICPP-1825_Create-Properties-at-compile-time to main July 20, 2023 06:31
extensions/azure/processors/ListAzureDataLakeStorage.h Outdated Show resolved Hide resolved
extensions/azure/storage/BlobStorageClient.h Outdated Show resolved Hide resolved
libminifi/include/utils/Enum.h Outdated Show resolved Hide resolved
libminifi/include/utils/Enum.h Outdated Show resolved Hide resolved
libminifi/include/utils/ProcessorConfigUtils.h Outdated Show resolved Hide resolved
@szaszm szaszm closed this in 6bc1965 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants