Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2221 Auto-generate CONTROLLERS.md #1665

Conversation

fgerlits
Copy link
Contributor

@fgerlits fgerlits commented Sep 22, 2023

  • Auto-generate CONTROLLERS.md
  • simplify the auto-generation of PROCESSORS.md: don't create individual files for each processor
  • add missing controller services to CONTROLLERS.md
  • move some descriptions from CONTROLLERS.md to the Description of the controller services
  • fix some Visual Studio warnings and a bug in formatAllowedValues().

https://issues.apache.org/jira/browse/MINIFICPP-2221


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Also:
* simplify the auto-generation of PROCESSORS.md: don't create individual files for each processor
* add missing controller services to CONTROLLERS.md
* move some descriptions from CONTROLLERS.md to the Description of the controller services
* fix some Visual Studio warnings and a bug in formatAllowedValues().
@fgerlits fgerlits force-pushed the MINIFICPP-2221_Auto-generate-CONTROLLERS-md branch from 00ee6e4 to d3df7c6 Compare September 22, 2023 07:39
libminifi/include/core/PropertyDefinition.h Outdated Show resolved Hide resolved
minifi_main/AgentDocs.cpp Outdated Show resolved Hide resolved
minifi_main/AgentDocs.cpp Outdated Show resolved Hide resolved
@szaszm szaszm closed this in 7e7984b Oct 2, 2023
@fgerlits fgerlits deleted the MINIFICPP-2221_Auto-generate-CONTROLLERS-md branch January 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants