Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2250 Do not strip core files in CI #1685

Closed
wants to merge 1 commit into from

Conversation

lordgamez
Copy link
Contributor

Core files were getting stripped in some cases making them unusable:
https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/6340288536
https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/6340287277
https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/6340278881

https://issues.apache.org/jira/browse/MINIFICPP-2250


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@szaszm
Copy link
Member

szaszm commented Oct 18, 2023

How large are they? Do we have enough free disk space left on the runners?

@lordgamez
Copy link
Contributor Author

How large are they? Do we have enough free disk space left on the runners?

The stripped core files I downloaded from the CI job were only 1.2MB, and when I tried to reproduce the issue locally I could make the test crash, but it only produced a 77MB core dump. I'm not sure why it was stripped as it should not exceed the current limit, but we recently added the step of removing the unneeded resources of the workers which frees up a few gigs that should be enough even if the crash dump is larger.

@martinzink martinzink closed this in 2b822cb Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants