MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow #1714
Conversation
… CI flow Co-authored-by: Martin Zink <martinzink@apache.org>
| if: failure() | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: behavex_output |
There was a problem hiding this comment.
If there are multiple failures, it will overwrite the uploaded file so only the last one will remain.
This might solve this issue (I didnt test it)
| name: behavex_output | |
| name: ${{ matrix.platform.name }}_behavex_output |
There was a problem hiding this comment.
Wouldn't you also have to rename the output on the source side?
There was a problem hiding this comment.
Based on this https://github.com/actions/upload-artifact?tab=readme-ov-file#upload-an-entire-directory the artifact name doesnt have to correlate to the source file/dir name so I think this might be sufficient. (Still havent tested it though)
There was a problem hiding this comment.
Good point, added an id prefix (to avoid spaces in the names) in b63e149 and tested it in https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/7475211172, seems to upload the correct artifacts for each platform.
https://issues.apache.org/jira/browse/MINIFICPP-2285
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.