Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2291 Fix site-to-site transfer of large files #1720

Conversation

fgerlits
Copy link
Contributor

Previously, the site-to-site client treated the TRANSACTION_FINISHED_BUT_DESTINATION_FULL message from the server as a failure, and kept rolling back and retrying the flow file.

Now, we treat it as success but add a yield so the server has time to clear the incoming connection, the same way as NiFi does.

https://issues.apache.org/jira/browse/MINIFICPP-2287
https://issues.apache.org/jira/browse/MINIFICPP-2291

I have also included the fix of two unrelated bugs I noticed during testing; these are too small to merit their own pull requests.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Previously, the site-to-site client treated the TRANSACTION_FINISHED_BUT_DESTINATION_FULL
message from the server as a failure, and kept rolling back and retrying the flow file.
Now, we treat it as success but add a yield so the server has time to clear the incoming
connection, the same way as NiFi does.
@szaszm szaszm closed this in 1a8ae2f Jan 25, 2024
@fgerlits fgerlits deleted the MINIFICPP-2291_Fix-site-to-site-transfer-of-large-files branch April 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants