MINIFICPP-2314 - Send asset state hash in heartbeat, implement c2 asset sync #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinzink
reviewed
Apr 5, 2024
| #include "utils/file/FileUtils.h" | ||
| #include "utils/file/AssetManager.h" | ||
|
|
||
| class FileProvider : public ServerAwareHandler { |
There was a problem hiding this comment.
Just noting for visibility that this will cause some conflict with #1749
lordgamez
reviewed
Apr 11, 2024
|
@adamdebreceni could you check out the the C2AssetSyncTest failure on windows? |
martinzink
approved these changes
May 3, 2024
lordgamez
approved these changes
May 3, 2024
adamdebreceni
force-pushed
the
MINIFICPP-2314
branch
2 times, most recently
from
17b1567
to
3ab1ce5
Compare
adamdebreceni
force-pushed
the
MINIFICPP-2314
branch
from
be322ec
to
f9d1871
Compare
fgerlits
reviewed
Jun 19, 2024
adamdebreceni
force-pushed
the
MINIFICPP-2314
branch
from
36fccc9
to
a791873
Compare
fgerlits
approved these changes
Jul 9, 2024
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
Co-authored-by: Martin Zink <martin.zink@protonmail.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
Co-authored-by: Ferenc Gerlits <fgerlits@users.noreply.github.com>
adamdebreceni
force-pushed
the
MINIFICPP-2314
branch
from
16a3eda
to
d32136b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.